[Fix #10605] Fix autocorrect for Style/RedundantCondition
#10606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobuyo
force-pushed
the
fix-autocorrect-for-style-redundant-condition-with-hash
branch
from
cf698dc
to
56bdb4f
Compare
koic
reviewed
May 7, 2022
| @@ -196,6 +200,10 @@ def require_parentheses?(node) | |||
| (node.respond_to?(:semantic_operator?) && node.semantic_operator?) | |||
| end | |||
|
|
|||
| def require_braces?(node) | |||
| node.hash_type? | |||
There was a problem hiding this comment.
It will get a syntax error in the following already braced case:
if foo
^^^^^^ Use double pipes `||` instead.
bar foo
else
bar({ baz => quux })
endAuto-corrected code is bar foo || { { baz => quux } }.
% ruby -ce "bar foo || { { baz => quux } }"
-e:1: syntax error, unexpected '}', expecting =>
bar foo || { { baz => quux } }Can you add the above test case and fix it?
There was a problem hiding this comment.
Thank you, fixed in 97c6273.
nobuyo
force-pushed
the
fix-autocorrect-for-style-redundant-condition-with-hash
branch
from
56bdb4f
to
97c6273
Compare
koic
reviewed
May 7, 2022
… argument for method in else branch is hash without braces Update spec/rubocop/cop/style/redundant_condition_spec.rb Co-authored-by: Koichi ITO <koic.ito@gmail.com>
nobuyo
force-pushed
the
fix-autocorrect-for-style-redundant-condition-with-hash
branch
from
1a908bb
to
e7885d0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...if argument for method in else branch is hash without braces.
Fixes #10605.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.