Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Style/SpecialGlobalVars #10541

Commits on Apr 15, 2022

  1. Fix an incorrect autocorrect for Style/SpecialGlobalVars

    This PR fixes the following incorrect autocorrect for `Style/SpecialGlobalVars`
    when global variable as Perl name is used multiple times.
    
    Example:
    
    ```ruby
    % cat example.rb
    $*[0]
    $*[1]
    
    % bundle exec rubocop --only Style/SpecialGlobalVars -A
    Inspecting 3 files
    .C.
    
    Offenses:
    
    example.rb:1:1: C: [Corrected] Style/SpecialGlobalVars: Prefer $ARGV
    from the stdlib 'English' module (don't forget to require it) or ARGV
    over $*.
    $*[0]
    ^^
    example.rb:2:1: C: [Corrected] Style/SpecialGlobalVars: Prefer $ARGV
    from the stdlib 'English' module (don't forget to require it) or ARGV
    over $*.
    $*[1]
    ^^
    
    3 files inspected, 2 offenses detected, 2 offenses corrected
    ```
    
    This auto-correction will add `require 'English'` twice:
    
    ```ruby
    % cat example.rb
    require 'English'
    require 'English'
    $ARGV[0]
    $ARGV[1]
    ```
    
    This PR ensures that `require 'English'` is added only once:
    
    ```ruby
    % cat example.rb
    require 'English'
    $ARGV[0]
    $ARGV[1]
    ```
    koic committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    290699e View commit details
    Browse the repository at this point in the history