[Fix #10529] Fix autocorrect for Style/SoleNestedConditional
#10532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobuyo
changed the title
Style/SoleNestedConditional causes…Style/SoleNestedConditional
|
CI / windows 3.1 has failed, but I have a feeling it's not due to my changes 🤔 |
|
I don't know if this is the right way to handle this, but wouldn't running CI again solve the problem? |
|
Yep, probably a false alarm due to an unstable test. |
koic
reviewed
Apr 13, 2022
koic
reviewed
Apr 13, 2022
|
I'd like to do |
|
This looks good. Can you squash your commits into one? |
… causes logical error when using a outer condition of method call by omitting parentheses for method arguments. Update changelog/fix_autocorrect_for_style_sole_nested_confitional.md Co-authored-by: Koichi ITO <koic.ito@gmail.com> Update spec/rubocop/cop/style/sole_nested_conditional_spec.rb Co-authored-by: Koichi ITO <koic.ito@gmail.com>
nobuyo
force-pushed
the
fix-style-sole-nested-conditional-correction
branch
from
8fecd94
to
a53d574
Compare
|
Thanks for your review, updated branch. |
|
Thanks! |
|
This fix works on 1.28.2, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10529
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.