Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10241] Fix last_column value for JSONFormatter #10242

Merged

Commits on Nov 12, 2021

  1. [Fix rubocop#10241] Fix last_column value for JSONFormatter

    Fixes rubocop#10241.
    
    This PR fixes `last_column` value for `JSONFormatter`.
    
    The minimum value of `start_column: real_column` is 1. So, the minimum value of `last_column` should be 1.
    And non-zero value of `last_column` should be used as is.
    
    This patch to `last_column` seems to be required only for `JSONFormatter` and not required for other formatters.
    
    It solves a potential `JSONFormatter` issue for cops that use `add_global_offense`.
    koic committed Nov 12, 2021
    Copy the full SHA
    965654f View commit details
    Browse the repository at this point in the history