[Fix #10174] Fix inherit_from_remote should follow remote includes path starting with ./
#10233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10174.
This PR is fix inherit_from_remote should follow remote includes path starting with
./
In the example of issue, it tries to load
./base.yml
in the same hierarchy asruby-2.7.yml
, but the uri of./base.yml
ishttps://raw.githubusercontent.com/testdouble/standard/main/config/./base.yml
.If the uri is
https:// ~ /./base.yml
, ConfigLoaderResolver#remote_file? returns false, so an instance of URI::Generic is created and an error occurs.In this PR, if remote includes path starts with
./
, it will be removed.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.