Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10200] Fix an error when inspecting a directory named * #10201

Merged

Conversation

koic
Copy link
Member

@koic koic commented Oct 20, 2021

Fixes #10200.

This PR fixes an error when inspecting a directory named *.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_error_when_inspecting_dir_named_wildcard branch from ebf959e to f8a767c Compare October 20, 2021 11:16
Fixes rubocop#10200.

This PR fixes an error when inspecting a directory named `*`.
@koic koic force-pushed the fix_error_when_inspecting_dir_named_wildcard branch from f8a767c to 63ea6e6 Compare October 20, 2021 11:32
@bbatsov bbatsov merged commit 34ce2ed into rubocop:master Oct 20, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 20, 2021

That's one curious bug. Thanks for tackling it!

@koic koic deleted the fix_error_when_inspecting_dir_named_wildcard branch October 20, 2021 15:26
@rotem-cider
Copy link

Great!! Thanks for fixing it so fast!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when scanning a directory with "*" subdirectory
3 participants