Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10165] Fix Layout/DotPosition false positives when the selector and receiver are on the same line #10168

Merged
merged 2 commits into from Oct 6, 2021

Conversation

dvandersluis
Copy link
Member

Yet another Layout/DotPosition false positive with heredocs 😅. This should hopefully fix all cases going forward because now it short circuits if the selector and receiver are on the same line.

Also updates Util#same_line? to be able to work with ranges in addition to nodes.

Fixes #10165.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/DotPosition with trailing style still fails autocorrect with heredoc arguments
1 participant