[Fix #10145] Update Style/SelectByRegexp
to ignore cases where the receiver appears to be a hash
#10155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
hash.grep
does not work in the same way as other enumerables, this update looks for receivers that look like hashes and does not registerStyle/SelectByRegexp
offenses on them. This includes literal hashes ({}
),Hash.new
,Hash[]
,to_h
andto_hash
(the latter two could potentially cause a false negative if they're overridden to not return hashes, but I can live with that).I added explicit tests for receivers that I have confirmed works as expected (array, range, set). In case we ever extend this with more exceptions those will be covered.
Fixes #10145.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.