Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10145] Update Style/SelectByRegexp to ignore cases where the receiver appears to be a hash #10155

Merged
merged 1 commit into from Oct 2, 2021

Conversation

dvandersluis
Copy link
Member

Since hash.grep does not work in the same way as other enumerables, this update looks for receivers that look like hashes and does not register Style/SelectByRegexp offenses on them. This includes literal hashes ({}), Hash.new, Hash[], to_h and to_hash (the latter two could potentially cause a false negative if they're overridden to not return hashes, but I can live with that).

I added explicit tests for receivers that I have confirmed works as expected (array, range, set). In case we ever extend this with more exceptions those will be covered.

Fixes #10145.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…re the receiver appears to be a hash.
@bbatsov bbatsov merged commit 31ea684 into rubocop:master Oct 2, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 2, 2021

Looks good!

@ghiculescu
Copy link
Contributor

@dvandersluis could you also exclude ENV here? I think is guaranteed to be a Hash

koic added a commit to koic/rubocop that referenced this pull request Mar 18, 2022
Follow up rubocop#10155 (comment).

This PR makes `Style/SelectByRegexp` aware of `ENV` const.
@koic
Copy link
Member

koic commented Mar 18, 2022

@ghiculescu That makes sense. I've opened #10457. Thank you for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/SelectByRegexp flags/autocorrects hash.select incorrectly
4 participants