[Fix #10148] Fix Style/QuotedSymbols handling escaped characters incorrectly
#10152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters incorrectly. Two cases are improved here: 1. Escaped double quotes (`\"`) within a double-quoted string are handled correctly (replaced with an unescaped double quote) when converting to a single-quoted string. 2. Escaped backslashes (`\\`) are treated properly and not doubled for both single- and double-quoted strings.
|
Thanks! |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Nov 2, 2021
Follow up to rubocop#10166 (comment). This PR fixes a false positive for `Style/StringLiterals` when `EnforcedStyle: double_quotes` and using single quoted string with backslash. It has moved a separate implementation for `Style/QuotedSymbols` to resolve rubocop#10152 to `Style/QuotedSymbols` to prevent impact on `Style/StringLiterals`'s false positives.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two cases are improved here:
\") within a double-quoted string are handled correctly (replaced with an unescaped double quote) when converting to a single-quoted string.\\) are treated properly and not doubled for both single- and double-quoted strings.Fixes #10148.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.