Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10134] Update Style/MutableConstant to not consider multiline uninterpolated strings as unfrozen in ruby 3.0 #10139

Merged
merged 1 commit into from Sep 29, 2021

Conversation

dvandersluis
Copy link
Member

In #10006 Style/MutableConstant was updated to consider dstr nodes as unfrozen in Ruby 3.0 even when frozen_string_literal: true is specified, and requires .freeze on those strings. However, a multiline string is considered a dstr node but does not contain interpolation so would still be frozen.

# frozen_string_literal: true

CONST = 'foo' \
        'bar'

CONST.frozen? #=> true

Fixes #10134.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ltiline uninterpolated strings as unfrozen in ruby 3.0.
@koic koic merged commit e21a318 into rubocop:master Sep 29, 2021
@koic
Copy link
Member

koic commented Sep 29, 2021

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/MutableConstant false positive with frozen_string_literal: true and line continuation
2 participants