Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9934] Fix configuration loading to not raise an error for an obsolete ruby version that is overridden #10112

Merged
merged 1 commit into from Sep 27, 2021

Conversation

dvandersluis
Copy link
Member

Previously, when a configuration file inherits another that sets TargetRubyVersion to an obsolete version, a config validation error is raised by RuboCop. This causes an irreconcilable issue if the inherited config is shared with other projects or not editable (from upstream, etc.).

In order to fix this, the target ruby version check is moved to happen after all the config resolution steps have completed, so at that point, all the various TargetRubyVersion values have been collapsed into a single value that can be verified. This allows for any number of complicated inheritence chains without causing issues.

Fixes #9934.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…r an obsolete ruby version that is subsequently overridden.
@bbatsov bbatsov merged commit d372598 into rubocop:master Sep 27, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 27, 2021

Nice fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when inheriting and overriding TargetRubyVersion
2 participants