[Fix #10106] Fix Style/RedundantSelf for pattern matching
#10108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Sep 23, 2021
dvandersluis
force-pushed
the
issue/10106
branch
from
66299be
to
7f3175a
Compare
|
@koic I have added quite a few more test cases for different types of pattern matching, which are all covered now. Thanks for the input! |
dvandersluis
force-pushed
the
issue/10106
branch
from
7f3175a
to
211af82
Compare
dvandersluis
force-pushed
the
issue/10106
branch
from
211af82
to
29f4a05
Compare
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
match-asnode creates a local variable within anin-patternnode that wasn't being registered byStyle/RedundantSelf.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.