[Fix #10066] Fix how MinDigits is calculated for Style/NumericLiterals when generating a configuration file
#10077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvandersluis
commented
Sep 13, 2021
| @@ -49,7 +49,7 @@ def _investigate(cop, processed_source) | |||
| team = RuboCop::Cop::Team.new([cop], nil, raise_error: true) | |||
| report = team.investigate(processed_source) | |||
| @last_corrector = report.correctors.first || RuboCop::Cop::Corrector.new(processed_source) | |||
| report.offenses | |||
| report.offenses.reject(&:disabled?) | |||
There was a problem hiding this comment.
In order to test this, I needed to update expect_offense and expect_no_offenses to not consider disabled offenses. There was only one test (in spec/rubocop/cop/layout/line_length_spec.rb) that was affected by this change.
koic
reviewed
Sep 14, 2021
…ricLiterals` when generating a configuration file.
dvandersluis
force-pushed
the
issue/10066
branch
from
76f5d5c
to
4036142
Compare
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
MinDigitsis incremented regardless of if the offense is disabled or not.Fixes #10066.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.