[Fix #9061] Add new Lint/IncompatibleIoSelectWithFiberScheduler cop
#10075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er` cop Fixes rubocop#9061. This PR adds new `Lint/IncompatibleIoSelectWithFiberScheduler` cop. It checks for `IO.select` that is incompatible with Fiber Scheduler since Ruby 3.0. ```ruby # bad IO.select([io], [], [], timeout) # good io.wait_readable(timeout) # bad IO.select([], [io], [], timeout) # good io.wait_writable(timeout) ``` Ref: `Fiber Scheduler` section of https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ This PR will make it possible to detect proven cases with redis/redis-rb#960.
|
Nice! |
koic
deleted the
new_add_new_incompatible_io_select_with_fiber_scheduler_cop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9061.
This PR adds new
Lint/IncompatibleIoSelectWithFiberSchedulercop.It checks for
IO.selectthat is incompatible with Fiber Scheduler since Ruby 3.0.Ref:
Fiber Schedulersection of https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/This PR will make it possible to detect proven cases with redis/redis-rb#960.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.