[Fix #10061] Fix a false positive for Style/RedundantSort
#10062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, why is this behaving differently for strings? |
koic
force-pushed
the
mark_style_redundant_sort_as_unsafe
branch
from
bacea01
to
2b2e16c
Compare
koic
changed the title
Style/RedundantSort as unsafeStyle/RedundantSort
koic
force-pushed
the
mark_style_redundant_sort_as_unsafe
branch
from
2b2e16c
to
a878752
Compare
|
Oops! That's my mistake. In fact, it is a false positive because using |
Fixes rubocop#10061. This PR fixes a false positive for `Style/RedundantSort` when using `size` method in the block.
koic
force-pushed
the
mark_style_redundant_sort_as_unsafe
branch
from
a878752
to
13e731b
Compare
|
Thanks! |
|
@koic Thanks! It was so quick! |
|
@Mifrill You're welcome! |
|
Is this the correct approach? If I understand it correctly, this is due to how a certain Ruby version handles ties differently between two different sorting methods. It seems a bit dangerous to rely on this tie-breaking result in our programs to begin with, as it can change between versions (or platforms, or implementations) based Ruby on internals. 😅 |
This was referenced Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10061.
This PR fixes a false positive for
Style/RedundantSortwhen usingsizemethod in the block.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.