Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10036] Mark Style/StructInheritance as unsafe auto-correction #10037

Conversation

koic
Copy link
Member

@koic koic commented Aug 24, 2021

Fixes #10036.

This PR marks Style/StructInheritance as unsafe auto-correction.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…rection

Fixes rubocop#10036.

This PR marks `Style/StructInheritance` as unsafe auto-correction.
@bbatsov bbatsov merged commit b00265b into rubocop:master Aug 24, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 24, 2021

Thanks!

@koic koic deleted the mark_style_struct_inheritance_as_unsafe_auto_correction branch August 24, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-correction of Style/StructInheritance may not be safe.
2 participants