Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10033] Fix an incorrect auto-correct for Style/BlockDelimiters #10035

Conversation

koic
Copy link
Member

@koic koic commented Aug 24, 2021

Fixes #10033.

This PR fixes an incorrect auto-correct for Style/BlockDelimiters when there is a comment after the closing brace and using method chain.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…imiters`

Fixes rubocop#10033.

This PR fixes an incorrect auto-correct for `Style/BlockDelimiters`
when there is a comment after the closing brace and using method chain.
@koic koic force-pushed the fix_an_incorrect_autocorrect_for_style_block_delimiters branch from d89940a to d2ebd34 Compare August 24, 2021 12:42
@bbatsov bbatsov merged commit 5574410 into rubocop:master Aug 24, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 24, 2021

Thanks!

@koic koic deleted the fix_an_incorrect_autocorrect_for_style_block_delimiters branch August 24, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants