Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10016] Fix conflict between Style/SoleNestedConditional and Style/NegatedIf or Style/NegatedUnless #10021

Merged
merged 1 commit into from Aug 17, 2021

Conversation

dvandersluis
Copy link
Member

When both Style/SoleNestedConditional and one of Style/NegatedIf or Style/NegatedUnless detect offenses on the same nested if, both corrections are applied, which results in the second clause of the resulting conditional to be inverted.

Fixes #10016.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…` and `Style/NegatedIf`/`Style/NegatedUnless`.
@dvandersluis dvandersluis requested a review from koic August 16, 2021 20:44
@koic koic merged commit 61971aa into rubocop:master Aug 17, 2021
@dvandersluis dvandersluis deleted the issue/10016 branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-correcting with Style/IfUnlessModifier and Style/SoleNestedConditional breaks code
2 participants