[Fix #10004] Fix a false positive for Style/RedundantBegin
#10005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_false_positive_for_style_redundant_begin
branch
2 times, most recently
from
c211ad7
to
a04d1af
Compare
bbatsov
reviewed
Aug 12, 2021
| @@ -131,6 +132,12 @@ def empty_begin?(node) | |||
| node.children.empty? | |||
| end | |||
|
|
|||
| def oneliner_with_semicolon?(node) | |||
There was a problem hiding this comment.
I think it's better to count the number of child nodes in the begin - it's one-line and has 1+ children they must be separated by semicolons, right?
There was a problem hiding this comment.
Right! And it should have been accepted if begin block has multiple statements, whether one-liner or multiple-lines. I also added several test cases and modified this implementation based on it.
Fixes rubocop#10004. This PR fixes a false positive for `Style/RedundantBegin` when using one-liner with semicolon.
koic
force-pushed
the
fix_false_positive_for_style_redundant_begin
branch
from
a04d1af
to
0723cce
Compare
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10004.
This PR fixes a false positive for
Style/RedundantBeginwhen using one-liner with semicolon.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.