Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10002] Fix an incorrect auto-correct for Lint/AmbigousRegexpLiteral #10003

Conversation

koic
Copy link
Member

@koic koic commented Aug 11, 2021

Fixes #10002.

This PR fixes an incorrect auto-correct for Lint/AmbigousRegexpLiteral when using nested method arguments without parentheses.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…egexpLiteral`

Fixes rubocop#10002.

This PR fixes an incorrect auto-correct for `Lint/AmbigousRegexpLiteral`
when using nested method arguments without parentheses.
@dvandersluis dvandersluis merged commit 7c4c927 into rubocop:master Aug 11, 2021
@dvandersluis
Copy link
Member

Thanks @koic!

@koic koic deleted the fix_incorrect_autocorrect_for_lint_ambiguous_regexp_literal branch August 11, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AmbigousRegexpLiteral autocorrect results to syntax error when multiple methods without paretheses
2 participants