Workaround for mingw build error #9808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR skips mingw build matrix due to the following build error.
```console
D:/ruby-mingw/lib/ruby/3.1.0/yaml.rb:3: warning: It seems your ruby
installation is missing psych (for YAML output).
To eliminate this warning, please install libyaml and reinstall your
ruby.
LoadError: 126: The specified module could not be found. -
D:/ruby-mingw/lib/ruby/3.1.0/x64-mingw32/psych.so
<internal:D:/ruby-mingw/lib/ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in
`require': 126: The specified module could not be found. -
D:/ruby-mingw/lib/ruby/3.1.0/x64-mingw32/psych.so (LoadError)
from
<internal:D:/ruby-mingw/lib/ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from D:/ruby-mingw/lib/ruby/3.1.0/psych.rb:13:in `<top (required)>'
from
<internal:D:/ruby-mingw/lib/ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from
<internal:D:/ruby-mingw/lib/ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from D:/ruby-mingw/lib/ruby/3.1.0/yaml.rb:4:in `<top (required)>'
from
<internal:D:/ruby-mingw/lib/ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from
<internal:D:/ruby-mingw/lib/ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/psyched_yaml.rb:12:in `<top (required)>'
from
D:/ruby-mingw/lib/ruby/3.1.0/bundler/rubygems_integration.rb:114:in `require_relative'
from
D:/ruby-mingw/lib/ruby/3.1.0/bundler/rubygems_integration.rb:114:in `configuration'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/fetcher.rb:247:in `connection'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/fetcher.rb:89:in `initialize'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/source/rubygems.rb:273:in `new'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/source/rubygems.rb:273:in `block in fetchers'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/source/rubygems.rb:271:in `map'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/source/rubygems.rb:271:in `fetchers'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/source/rubygems.rb:407:in `block in remote_specs'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/index.rb:9:in `build'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/source/rubygems.rb:406:in `remote_specs'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/source/rubygems.rb:104:in `specs'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/definition.rb:296:in `block (2 levels) in index'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/definition.rb:294:in `each'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/definition.rb:294:in `block in index'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/index.rb:9:in `build'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/definition.rb:291:in `index'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/definition.rb:913:in `source_requirements'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/definition.rb:285:in `resolve'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/definition.rb:176:in `resolve_remotely!'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/installer.rb:291:in `resolve_if_needed'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/installer.rb:83:in `block in run'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/process_lock.rb:12:in `block in lock'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/process_lock.rb:9:in `open'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/process_lock.rb:9:in `lock'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/installer.rb:72:in `run'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/installer.rb:24:in `install'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/cli/install.rb:60:in `run'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/cli.rb:259:in `block in install'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/settings.rb:133:in `temporary'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/cli.rb:258:in `install'
from
D:/ruby-mingw/lib/ruby/3.1.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
from
D:/ruby-mingw/lib/ruby/3.1.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
from
D:/ruby-mingw/lib/ruby/3.1.0/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/cli.rb:30:in `dispatch'
from
D:/ruby-mingw/lib/ruby/3.1.0/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/cli.rb:24:in `start'
from
D:/ruby-mingw/lib/ruby/gems/3.1.0/gems/bundler-2.3.0.dev/libexec/bundle:49:in `block in <top (required)>'
from D:/ruby-mingw/lib/ruby/3.1.0/bundler/friendly_errors.rb:130:in `with_friendly_errors'
from
D:/ruby-mingw/lib/ruby/gems/3.1.0/gems/bundler-2.3.0.dev/libexec/bundle:37:in
`<top (required)>'
from D:/ruby-mingw/bin/bundle:31:in `load'
from D:/ruby-mingw/bin/bundle:31:in `<main>'
```
https://github.com/rubocop/rubocop/pull/9806/checks?check_run_id=2601617298
|
I came across this somehow... Anyway, the issue has been fixed with the mingw build, I just reverted the commit for this in my fork. See: https://github.com/MSP-Greg/rubocop/actions/runs/907498063 I can do a PR or you can revert the commit. Feel free to ping me if you see mingw issues anywhere. The MSYS2 org has had many changes recently, things like new gpg keys, changes to the sites hosting the packages, etc. I prefer to not update all the MSYS2 packages (can take a long time), and partial updates occasionally failed in the past. I adjusted code for it in ruby-loco and setup-ruby-pkgs, I doubt there will be problems in the future. Thanks. |
|
@MSP-Greg Great! Thank you for the mention! Can you open a pull request? |
8 tasks
koic
added a commit
that referenced
this pull request
Jun 5, 2021
Revert "Merge pull request #9808" - fix MinGW CI
|
@MSP-Greg It seems that |
|
I think I just fixed it, the job is running right now (16:47 UTC)... Sorry. About 35 minutes I should be able to verify the fix |
|
Awesome! Thank you for the quick fix! |
|
It's still not fixed. I'm working on it... |
|
I guess when you make changes to speed things up when working locally, and then you accidentally commit them, the fix for the original problem won't work in CI... Anyway, it's fixed. Sorry for the delay. |
|
I confirmed that CI build has been recovered. Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips mingw build matrix due to the following build error.
https://github.com/rubocop/rubocop/pull/9806/checks?check_run_id=2601617298
I reported the issue to ruby/psych#494.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.