Suppress RuboCop 1.8's new offense #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is not related to this PR change because it is the same error as below. |
This PR suppresses and auto-corrects the following RuboCop 1.8's new offense.
```console
% bundle exec rubocop -a
(snip)
Inspecting 3 files
CCC
Offenses:
lib/rubocop/ast/node_pattern/compiler/sequence_subcompiler.rb:350:13: C:
[Corrected] Layout/LineEndStringConcatenationIndentation: Indent the
first part of a string concatenated with backslash.
"#{@cur_child_var} || true)"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/rubocop/ast/node_pattern/parser.rb:55:13: C: [Corrected]
Layout/LineEndStringConcatenationIndentation: Align parts of a string
concatenated with backslash.
"but got expression matching multiple elements: #{detail}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/rubocop/ast/node_pattern_spec.rb:948:9: C: [Corrected]
Layout/LineEndStringConcatenationIndentation: Indent the first part of a
string concatenated with backslash.
'[!nil {($_ sym $_) (send ($_ $_) :object_id)}]}'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3 files inspected, 3 offenses detected, 3 offenses corrected
```
koic
force-pushed
the
suppress_rubocop_18_new_offense
branch
from
ad33261
to
0d8c631
Compare
|
Thanks @koic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses and auto-corrects the following RuboCop 1.8's new offense.