New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: rubocop 1.45.0 crashes when we use rubocop-i18n #11549
Labels
Comments
koic
added a commit
to koic/rubocop
that referenced
this issue
Feb 8, 2023
Fixes rubocop#11549. This PR fixes an error for third party cops when inheriting `RuboCop::Cop::Cop`. It makes the same changes to `RuboCop::Cop::Cop` as `RuboCop::Cop::Base` in rubocop#10839. Confirmed that rubocop-i18n tests pass again.
This was referenced Feb 8, 2023
Same issue in our build/test pipeline. It's blocking our ability to merge code. Can be this fixed soon please? |
instructure-gerrit
pushed a commit
to instructure/canvas-lms
that referenced
this issue
Feb 8, 2023
this is a temporary version lock to avoid a bug in rubocop 1.45.0 rubocop/rubocop#11549 Change-Id: Ibc0f90c6d3ebaaa0857e2e8b265d2a6585e9fe17 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/310676 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Aaron Ogata <aogata@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
bbatsov
pushed a commit
that referenced
this issue
Feb 8, 2023
benlangfeld
added a commit
to powerhome/power-tools
that referenced
this issue
Feb 8, 2023
The bug that caused all the drama [was fixed already](rubocop/rubocop#11549).
that-jill
pushed a commit
to powerhome/power-tools
that referenced
this issue
Feb 8, 2023
* Allow new rubocop versions The bug that caused all the drama [was fixed already](rubocop/rubocop#11549). * Version bump * Bump lockfiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After upgrading rubocop 1.45.0, rubocop crashes:
This seems to be introduced at 3c9c494.
Before:
After:
RuboCop::Cop::Base#begin_investigation
is moved to public section,but
RuboCop::Cop::Cop#begin_investigation
is still in private section.rubocop-i18n
's cops are extended fromRuboCop::Cop::Cop
instead ofBase
.Expected behavior
Rubocop works with no errors.
Actual behavior
Rubocop crashes.
Steps to reproduce the problem
RuboCop version
The text was updated successfully, but these errors were encountered: