Skip to content

Commit

Permalink
pin rubocop to 1.44.1 in rubocop-canvas gem
Browse files Browse the repository at this point in the history
this is a temporary version lock to avoid a bug in rubocop 1.45.0
rubocop/rubocop#11549

Change-Id: Ibc0f90c6d3ebaaa0857e2e8b265d2a6585e9fe17
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/310676
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
  • Loading branch information
kerby82 authored and SaltNPepa committed Feb 8, 2023
1 parent 9563783 commit 2387a36
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Gemfile.rails61.lock.partial
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ PATH
activesupport (>= 6.0)
jira_ref_parser (= 1.0.1)
outrigger (~> 3.0)
rubocop (~> 1.19)
rubocop (<= 1.44.1)

PATH
remote: gems
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.rails70.lock.partial
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ PATH
activesupport (>= 6.0)
jira_ref_parser (= 1.0.1)
outrigger (~> 3.0)
rubocop (~> 1.19)
rubocop (<= 1.44.1)

PATH
remote: gems
Expand Down
4 changes: 3 additions & 1 deletion gems/rubocop-canvas/rubocop-canvas.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ Gem::Specification.new do |spec|
spec.add_dependency "activesupport", ">= 6.0"
spec.add_dependency "jira_ref_parser", "1.0.1"
spec.add_dependency "outrigger", "~> 3.0"
spec.add_dependency "rubocop", "~> 1.19"
# FIXME: this is a temporary version lock to avoid a bug in rubocop 1.45.0
# https://github.com/rubocop/rubocop/issues/11549
spec.add_dependency "rubocop", "<=1.44.1"

spec.add_development_dependency "bundler", "~> 2.2"
spec.add_development_dependency "byebug"
Expand Down

0 comments on commit 2387a36

Please sign in to comment.