Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #11492] Fix an error for Lint/Void #11493

Merged
merged 1 commit into from Jan 24, 2023

Conversation

koic
Copy link
Member

@koic koic commented Jan 24, 2023

Fixes #11492.

This PR fixes an error for Lint/Void when configuring CheckForMethodsWithNoSideEffects: true.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_an_error_for_lint_void branch from 11e8eda to 75095d0 Compare January 24, 2023 12:00
Fixes rubocop#11492.

This PR fixes an error for `Lint/Void` when configuring `CheckForMethodsWithNoSideEffects: true`.
@koic koic force-pushed the fix_an_error_for_lint_void branch from 75095d0 to 48f3d1f Compare January 24, 2023 12:03
@koic koic merged commit aa08c25 into rubocop:master Jan 24, 2023
@koic koic deleted the fix_an_error_for_lint_void branch January 24, 2023 16:19
@tsugimoto
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/Void errors with CheckForMethodsWithNoSideEffects: true
2 participants