Merge pull request #11493 from koic/fix_an_error_for_lint_void

[Fix #11492] Fix an error for `Lint/Void`
rubocop · Jan 24, 2023 · aa08c25 · aa08c25
2 parents 9a1f19a + 48f3d1f
commit aa08c25
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/changelog/fix_an_error_for_lint_void.md b/changelog/fix_an_error_for_lint_void.md
@@ -0,0 +1 @@
+* [#11492](https://github.com/rubocop/rubocop/issues/11492): Fix an error for `Lint/Void` when configuring `CheckForMethodsWithNoSideEffects: true`. ([@koic][])
diff --git a/lib/rubocop/cop/lint/void.rb b/lib/rubocop/cop/lint/void.rb
@@ -128,6 +128,8 @@ def check_void_expression(node)
         end
 
         def check_nonmutating(node)
+          return unless node.respond_to?(:method_name)
+
           method_name = node.method_name
           return unless NONMUTATING_METHODS.include?(method_name)
 

diff --git a/spec/rubocop/cop/lint/void_spec.rb b/spec/rubocop/cop/lint/void_spec.rb
@@ -255,6 +255,13 @@ def foo
         top(x)
       RUBY
     end
+
+    it 'does not register an offense assigning variable' do
+      expect_no_offenses(<<~RUBY)
+        foo = bar
+        baz
+      RUBY
+    end
   end
 
   context 'when not checking for methods with no side effects' do