[Fix #11123 ] Fix auto correction bug for Style/StringLiterals #11144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Nov 3, 2022
| @@ -93,7 +93,7 @@ def correct_quotes(str) | |||
| end | |||
|
|
|||
| # The conversion process doubles escaped slashes, so they have to be reverted | |||
| correction.gsub('\\\\', '\\') | |||
| correction.gsub('\\\\', '\\').gsub('\"', '"') | |||
There was a problem hiding this comment.
That change was made to keep this test passing. It was the only one to fail after the change was made in lib/rubocop/cop/util.rb
|
This looks good to me. Can you add a changelog entry? Please see the end of the PR check items for details. |
|
@si-lens ping :-) |
si-lens
force-pushed
the
fix_auto_correction_bug_for_Style/StringLiterals
branch
from
94b5862
to
7facde9
Compare
Oh right, forgot about it! |
koic
reviewed
Nov 12, 2022
| @@ -0,0 +1 @@ | |||
| * [#11123](https://github.com/rubocop/rubocop/issues/11123): Fix autocorrection bug for `Style/StringLiterals` when using multiple escape characters. ([@si-lens][]) | |||
There was a problem hiding this comment.
CI is failing. Can you insert the newline to make the test below pass?
% bundle exec rspec spec/project_spec.rb
(snip)
Failures:
1) RuboCop Project Changelog future entries For /home/circleci/project/spec/../changelog/fix_auto_correction_bug_for_string_literals.md has newline at end of file
Failure/Error: expect(changelog.end_with?("\n")).to be true
si-lens
force-pushed
the
fix_auto_correction_bug_for_Style/StringLiterals
branch
from
7facde9
to
45da59a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #11123
Before:
was corrected to:
These two strings are not the same.
After my changes it should result in correct string:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.