[Fix #11123 ] Fix auto correction bug for Style/StringLiterals

rubocop · Nov 12, 2022 · 45da59a · 45da59a
1 parent 41a8249
commit 45da59a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/changelog/fix_auto_correction_bug_for_string_literals.md b/changelog/fix_auto_correction_bug_for_string_literals.md
@@ -0,0 +1 @@
+* [#11123](https://github.com/rubocop/rubocop/issues/11123): Fix autocorrection bug for `Style/StringLiterals` when using multiple escape characters. ([@si-lens][])
diff --git a/lib/rubocop/cop/style/quoted_symbols.rb b/lib/rubocop/cop/style/quoted_symbols.rb
@@ -93,7 +93,7 @@ def correct_quotes(str)
                        end
 
           # The conversion process doubles escaped slashes, so they have to be reverted
-          correction.gsub('\\\\', '\\')
+          correction.gsub('\\\\', '\\').gsub('\"', '"')
         end
 
         def style

diff --git a/lib/rubocop/cop/util.rb b/lib/rubocop/cop/util.rb
@@ -122,7 +122,7 @@ def to_string_literal(string)
           string.inspect
         else
           # In a single-quoted strings, double quotes don't need to be escaped
-          "'#{string.gsub('\"', '"').gsub('\\') { '\\\\' }}'"
+          "'#{string.gsub('\\') { '\\\\' }.gsub('\"', '"')}'"
         end
       end
 

diff --git a/spec/rubocop/cop/style/string_literals_spec.rb b/spec/rubocop/cop/style/string_literals_spec.rb
@@ -14,6 +14,8 @@
            ^^^^^ Prefer single-quoted strings when you don't need string interpolation or special symbols.
         z = "a\\"
             ^^^^^ Prefer single-quoted strings when you don't need string interpolation or special symbols.
+        t = "{\"[\\\"*\\\"]\""
+            ^^^^^^^^^^^^^^^^^^ Prefer single-quoted strings when you don't need string interpolation or special symbols.
       RUBY
       expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'double_quotes')
 
@@ -22,6 +24,7 @@
         x = 'a\\b'
         y ='\\b'
         z = 'a\\'
+        t = '{"[\"*\"]"'
       RUBY
     end