Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10143] Fix an error for Lint/RequireRelativeSelfPath #10146

Merged

Conversation

koic
Copy link
Member

@koic koic commented Sep 29, 2021

Fixes #10143.

This PR fixes an error for Lint/RequireRelativeSelfPath when using a variable as an argument of require_relative.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#10143.

This PR fixes an error for `Lint/RequireRelativeSelfPath`
when using a variable as an argument of `require_relative`.
@koic koic merged commit efcf741 into rubocop:master Sep 29, 2021
@koic koic deleted the fix_an_error_for_lint_require_relative_self_path branch September 29, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/RequireRelativeSelfPath crash if require_relative is called with a variable instead of a string literal
2 participants