Merge pull request #9671 from koic/fix_incorrect_autocorrect_for_ambi…

…guous_operator

Fix an incorrect auto-correct for `Lint/AmbiguousOperator`

changelog/fix_incorrect_autocorrect_for_ambiguous_operator.md

@@ -0,0 +1 @@
+* [#9671](https://github.com/rubocop/rubocop/pull/9671): Fix an incorrect auto-correct for `Lint/AmbiguousOperator` with `Style/MethodCallWithArgsParentheses`. ([@koic][])

lib/rubocop/cop/util.rb

@@ -38,7 +38,10 @@ def add_parentheses(node, corrector)
         elsif node.arguments.empty?
           corrector.insert_after(node, '()')
         else
-          corrector.replace(args_begin(node), '(')
+          args_begin = args_begin(node)
+
+          corrector.remove(args_begin)
+          corrector.insert_before(args_begin, '(')
           corrector.insert_after(args_end(node), ')')
         end
       end

spec/rubocop/cli/autocorrect_spec.rb

@@ -236,6 +236,29 @@ def batch
     RUBY
   end
 
+  it 'corrects `EnforcedStyle: require_parentheses` of `Style/MethodCallWithArgsParentheses` with ' \
+     '`Lint/AmbiguousOperator`' do
+    create_file('.rubocop.yml', <<~YAML)
+      Style/MethodCallWithArgsParentheses:
+        EnforcedStyle: require_parentheses
+    YAML
+    create_file('example.rb', <<~RUBY)
+      def foo(&block)
+        do_something &block
+      end
+    RUBY
+    expect(
+      cli.run(
+        ['--auto-correct', '--only', 'Style/MethodCallWithArgsParentheses,Lint/AmbiguousOperator']
+      )
+    ).to eq(0)
+    expect(IO.read('example.rb')).to eq(<<~RUBY)
+      def foo(&block)
+        do_something(&block)
+      end
+    RUBY
+  end
+
   it 'corrects `Style/IfUnlessModifier` with `Style/SoleNestedConditional`' do
     source = <<~RUBY
       def foo