Autocorrect '\\' when double-quotes are preferred

rubocop · Apr 29, 2021 · f4bdb3d · f4bdb3d
1 parent 74377b0
commit f4bdb3d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/changelog/fix_autocorrect_when_doublequotes_are.md b/changelog/fix_autocorrect_when_doublequotes_are.md
@@ -0,0 +1 @@
+* [#9751](https://github.com/rubocop/rubocop/pull/9751): `Style/StringLiteral` autocorrects `'\\'` into `"\\"`. ([@etiennebarrie][])
diff --git a/lib/rubocop/cop/mixin/string_literals_help.rb b/lib/rubocop/cop/mixin/string_literals_help.rb
@@ -15,7 +15,7 @@ def wrong_quotes?(node)
         if style == :single_quotes
           !double_quotes_required?(src)
         else
-          !/" | \\[^'] | \#(@|\{)/x.match?(src)
+          !/" | \\[^'\\] | \#(@|\{)/x.match?(src)
         end
       end
     end

diff --git a/spec/rubocop/cop/style/string_literals_spec.rb b/spec/rubocop/cop/style/string_literals_spec.rb
@@ -206,10 +206,13 @@
       expect_offense(<<~'RUBY')
         '\''
         ^^^^ Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+        '\\'
+        ^^^^ Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
       RUBY
 
       expect_correction(<<~'RUBY')
         "'"
+        "\\"
       RUBY
     end