Merge pull request #8780 from dvandersluis/fix/layout-assignment-inde…

…ntation-infinite-loop

[Fix #8774] Fix false positive with `Layout/ArrayAlignment` for parallel assignment

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bug fixes
+
+* [#8774](https://github.com/rubocop-hq/rubocop/issues/8774): Fix a false positive for `Layout/ArrayAlignment` with parallel assignment. ([@dvandersluis][])
+
 ## 0.91.1 (2020-09-23)
 
 ### Bug fixes

lib/rubocop/cop/layout/array_alignment.rb

@@ -44,6 +44,7 @@ class ArrayAlignment < Cop
 
         def on_array(node)
           return if node.children.size < 2
+          return if node.parent&.masgn_type?
 
           check_alignment(node.children, base_column(node, node.children))
         end

spec/rubocop/cop/layout/array_alignment_spec.rb

@@ -169,6 +169,13 @@
         ]
       RUBY
     end
+
+    it 'does not register an offense or try to correct parallel assignment' do
+      expect_no_offenses(<<~RUBY)
+        thing, foo =
+          1, 2
+      RUBY
+    end
   end
 
   context 'when aligned with fixed indentation' do
@@ -328,5 +335,12 @@
         ]
       RUBY
     end
+
+    it 'does not register an offense or try to correct parallel assignment' do
+      expect_no_offenses(<<~RUBY)
+        thing, foo =
+          1, 2
+      RUBY
+    end
   end
 end