Skip to content

Commit

Permalink
[Fix #7936] Mark Lint/BooleanSymbol as unsafe (#7941)
Browse files Browse the repository at this point in the history
  • Loading branch information
laurmurclar committed May 10, 2020
1 parent 4a41a06 commit e95daf9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -30,6 +30,7 @@
* [#7094](https://github.com/rubocop-hq/rubocop/issues/7094): Clarify alignment in `Layout/MultilineOperationIndentation`. ([@jonas054][])
* [#4245](https://github.com/rubocop-hq/rubocop/issues/4245): **(Breaking)** Inspect all files given on command line unless `--only-recognized-file-types` is given. ([@jonas054][])
* [#7390](https://github.com/rubocop-hq/rubocop/issues/7390): **(Breaking)** Enabling a cop overrides disabling its department. ([@jonas054][])
* [#7936](https://github.com/rubocop-hq/rubocop/issues/7936): Mark `Lint/BooleanSymbol` as unsafe. ([@laurmurclar][])

## 0.82.0 (2020-04-16)

Expand Down Expand Up @@ -4490,3 +4491,4 @@
[@DracoAter]: https://github.com/DracoAter
[@diogoosorio]: https://github.com/diogoosorio
[@jeffcarbs]: https://github.com/jeffcarbs
[@laurmurclar]: https://github.com/laurmurclar
3 changes: 2 additions & 1 deletion config/default.yml
Expand Up @@ -1342,8 +1342,9 @@ Lint/BigDecimalNew:
Lint/BooleanSymbol:
Description: 'Check for `:true` and `:false` symbols.'
Enabled: true
Safe: false
VersionAdded: '0.50'
VersionChanged: '0.81'
VersionChanged: '0.83'

Lint/CircularArgumentReference:
Description: "Default values in optional keyword arguments and optional ordinal arguments should not refer back to the name of the argument."
Expand Down
2 changes: 1 addition & 1 deletion manual/cops_lint.md
Expand Up @@ -166,7 +166,7 @@ BigDecimal(123.456, 3)

Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
--- | --- | --- | --- | ---
Enabled | Yes | Yes | 0.50 | 0.81
Enabled | No | Yes (Unsafe) | 0.50 | 0.83

This cop checks for `:true` and `:false` symbols.
In most cases it would be a typo.
Expand Down

0 comments on commit e95daf9

Please sign in to comment.