Merge pull request #8661 from koic/fix_false_positive_for_style_multi…

…line_ternary_operator

Fix an incorrect auto-correct for `Style/MultilineTernaryOperator`

CHANGELOG.md

@@ -32,6 +32,7 @@
 * [#8626](https://github.com/rubocop-hq/rubocop/issues/8626): Fix false negatives for `Lint/UselessMethodDefinition`. ([@marcandre][])
 * [#8698](https://github.com/rubocop-hq/rubocop/pull/8698): Fix cache to avoid encoding exception. ([@marcandre][])
 * [#8704](https://github.com/rubocop-hq/rubocop/issues/8704): Fix an error for `Lint/AmbiguousOperator` when using safe navigation operator with a unary operator. ([@koic][])
+* [#8661](https://github.com/rubocop-hq/rubocop/pull/8661): Fix an incorrect auto-correct for `Style/MultilineTernaryOperator` when returning a multiline ternary operator expression. ([@koic][])
 
 ### Changes
 

docs/modules/ROOT/pages/cops_style.adoc

@@ -5757,6 +5757,9 @@ end
 
 This cop checks for multi-line ternary op expressions.
 
+NOTE: `return if ... else ... end` is syntax error. If `return` is used before
+multiline ternary operator expression, it cannot be auto-corrected.
+
 === Examples
 
 [source,ruby]

lib/rubocop/cop/style/multiline_ternary_operator.rb

@@ -5,6 +5,9 @@ module Cop
     module Style
       # This cop checks for multi-line ternary op expressions.
       #
+      # NOTE: `return if ... else ... end` is syntax error. If `return` is used before
+      # multiline ternary operator expression, it cannot be auto-corrected.
+      #
       # @example
       #   # bad
       #   a = cond ?
@@ -29,9 +32,13 @@ class MultilineTernaryOperator < Base
               'use `if` or `unless` instead.'
 
         def on_if(node)
-          return unless node.ternary? && node.multiline?
+          return unless offense?(node)
 
           add_offense(node) do |corrector|
+            # `return if ... else ... end` is syntax error. If `return` is used before
+            # multiline ternary operator expression, it cannot be auto-corrected.
+            next unless offense?(node) && !node.parent.return_type?
+
             corrector.replace(node, <<~RUBY.chop)
               if #{node.condition.source}
                 #{node.if_branch.source}
@@ -41,6 +48,12 @@ def on_if(node)
             RUBY
           end
         end
+
+        private
+
+        def offense?(node)
+          node.ternary? && node.multiline?
+        end
       end
     end
   end

spec/rubocop/cop/style/multiline_ternary_operator_spec.rb

@@ -53,6 +53,17 @@
     RUBY
   end
 
+  it 'register an offense and does not auto-correct when returning a multiline ternary operator expression' do
+    expect_offense(<<~RUBY)
+      return cond ?
+             ^^^^^^ Avoid multi-line ternary operators, use `if` or `unless` instead.
+             foo :
+             bar
+    RUBY
+
+    expect_no_corrections
+  end
+
   it 'accepts a single line ternary operator expression' do
     expect_no_offenses('a = cond ? b : c')
   end