[Fix #5953] Fix a false positive for Style/AccessModifierDeclarations

Fixes #5953. This PR fixes a false positive for `Style/AccessModifierDeclarations` when using `module_function` with symbol.
rubocop · Mar 23, 2021 · c5913b3 · c5913b3
1 parent 98ff684
commit c5913b3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/changelog/fix_a_false_positive_for_style_access_modifier_declarations.md b/changelog/fix_a_false_positive_for_style_access_modifier_declarations.md
@@ -0,0 +1 @@
+* [#5953](https://github.com/rubocop/rubocop/issues/5953): Fix a false positive for `Style/AccessModifierDeclarations` when using `module_function` with symbol. ([@koic][])
diff --git a/lib/rubocop/cop/style/access_modifier_declarations.rb b/lib/rubocop/cop/style/access_modifier_declarations.rb
@@ -79,7 +79,7 @@ class AccessModifierDeclarations < Base
 
         # @!method access_modifier_with_symbol?(node)
         def_node_matcher :access_modifier_with_symbol?, <<~PATTERN
-          (send nil? {:private :protected :public} (sym _))
+          (send nil? {:private :protected :public :module_function} (sym _))
         PATTERN
 
         def on_send(node)

diff --git a/spec/rubocop/cop/style/access_modifier_declarations_spec.rb b/spec/rubocop/cop/style/access_modifier_declarations_spec.rb
@@ -46,7 +46,7 @@ class Foo
       }
     end
 
-    %w[private protected public].each do |access_modifier|
+    %w[private protected public module_function].each do |access_modifier|
       it "offends when #{access_modifier} is inlined with a method" do
         expect_offense(<<~RUBY, access_modifier: access_modifier)
           class Test
@@ -108,7 +108,7 @@ class TestThree
       }
     end
 
-    %w[private protected public].each do |access_modifier|
+    %w[private protected public module_function].each do |access_modifier|
       it "offends when #{access_modifier} is not inlined" do
         expect_offense(<<~RUBY, access_modifier: access_modifier)
           class Test