[Fix #9689] Treat parens around array items the same for children and…

… deeper descendants.
rubocop · Apr 19, 2021 · c53803b · c53803b
1 parent 6136239
commit c53803b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 7 deletions.
diff --git a/changelog/fix_treat_parens_around_array_items_the_same.md b/changelog/fix_treat_parens_around_array_items_the_same.md
@@ -0,0 +1 @@
+* [#9689](https://github.com/rubocop/rubocop/issues/9689): Treat parens around array items the same for children and deeper descendants. ([@dvandersluis][])
diff --git a/lib/rubocop/cop/style/redundant_parentheses.rb b/lib/rubocop/cop/style/redundant_parentheses.rb
@@ -158,15 +158,11 @@ def allowed_array_or_hash_element?(node)
           # { a: (1
           #      ), }
           # ```
-          (hash_element?(node) || array_element?(node)) && only_closing_paren_before_comma?(node)
+          hash_or_array_element?(node) && only_closing_paren_before_comma?(node)
         end
 
-        def hash_element?(node)
-          node.parent&.pair_type?
-        end
-
-        def array_element?(node)
-          node.parent&.array_type?
+        def hash_or_array_element?(node)
+          node.each_ancestor(:array, :hash).any?
         end
 
         def only_closing_paren_before_comma?(node)

diff --git a/spec/rubocop/cop/style/redundant_parentheses_spec.rb b/spec/rubocop/cop/style/redundant_parentheses_spec.rb
@@ -162,6 +162,24 @@
 
   it_behaves_like 'plausible', "[(1\n),]"
 
+  it_behaves_like 'plausible', <<~RUBY
+    [
+      (
+        1
+      ),
+      2
+    ]
+  RUBY
+
+  it_behaves_like 'plausible', <<~RUBY
+    [
+      x = (
+        1
+      ),
+      y = 2
+    ]
+  RUBY
+
   it 'registers an offense for parens around a literal hash value' do
     expect_offense(<<~RUBY)
       {a: (1)}