Skip to content

Commit

Permalink
Revert "Workaround to skip some tests when using JRuby"
Browse files Browse the repository at this point in the history
This reverts commit 7743366.

jruby/jruby#5968 has been solved by JRuby 9.2.12.0.
  • Loading branch information
koic authored and bbatsov committed Jul 20, 2020
1 parent cfa036e commit c1faddf
Showing 1 changed file with 4 additions and 13 deletions.
17 changes: 4 additions & 13 deletions spec/rubocop/cop/style/parallel_assignment_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -87,20 +87,11 @@
RUBY
it_behaves_like('allowed', 'a, b = Float::INFINITY')
it_behaves_like('allowed', 'a[0], a[1] = a[1], a[0]')
it_behaves_like('allowed', 'obj.attr1, obj.attr2 = obj.attr2, obj.attr1')
it_behaves_like('allowed', 'obj.attr1, ary[0] = ary[0], obj.attr1')
it_behaves_like('allowed', 'ary[0], ary[1], ary[2] = ary[1], ary[2], ary[0]')

# FIXME: Remove `RUBY_ENGINE` condition, which works around
# a JRuby 9.2.9.0 regression:
# https://github.com/jruby/jruby/issues/5968
# Originally, both MRI and JRuby are successful tests.
# The tests fail as follows:
# https://circleci.com/gh/rubocop-hq/rubocop/74069
unless RUBY_ENGINE == 'jruby'
it_behaves_like('allowed', 'obj.attr1, obj.attr2 = obj.attr2, obj.attr1')
it_behaves_like('allowed', 'obj.attr1, ary[0] = ary[0], obj.attr1')
it_behaves_like('allowed', 'self.a, self.b = self.b, self.a')
it_behaves_like('allowed', 'self.a, self.b = b, a')
end
it_behaves_like('allowed', 'self.a, self.b = self.b, self.a')
it_behaves_like('allowed', 'self.a, self.b = b, a')

it 'highlights the entire expression' do
expect_offense(<<~RUBY)
Expand Down

0 comments on commit c1faddf

Please sign in to comment.