Merge pull request #7897 from tejasbubane/generator-version-added

Allow Generator to take version_added parameter
rubocop · May 9, 2020 · bea4bf1 · bea4bf1
2 parents 75542a8 + 9459cb6
commit bea4bf1
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/lib/rubocop/cop/generator.rb b/lib/rubocop/cop/generator.rb
@@ -132,11 +132,12 @@ def inject_require(root_file_path: 'lib/rubocop.rb')
         ).inject
       end
 
-      def inject_config(config_file_path: 'config/default.yml')
+      def inject_config(config_file_path: 'config/default.yml',
+                        version_added: bump_minor_version)
         injector =
           ConfigurationInjector.new(configuration_file_path: config_file_path,
                                     badge: badge,
-                                    version_added: bump_minor_version)
+                                    version_added: version_added)
 
         injector.inject do
           output.puts(format(CONFIGURATION_ADDED_MESSAGE,

diff --git a/spec/rubocop/cop/generator_spec.rb b/spec/rubocop/cop/generator_spec.rb
@@ -280,6 +280,28 @@ def on_send(node)
                  "#{path}.\n")
       end
     end
+
+    context 'with version provided' do
+      it 'uses the provided version' do
+        expect(File).to receive(:write).with(path, <<~YAML)
+          Style/Alias:
+            Enabled: true
+
+          Style/FakeCop:
+            Description: 'TODO: Write a description of the cop.'
+            Enabled: pending
+            VersionAdded: '1.52'
+
+          Style/Lambda:
+            Enabled: true
+
+          Style/SpecialGlobalVars:
+            Enabled: true
+        YAML
+
+        generator.inject_config(config_file_path: path, version_added: '1.52')
+      end
+    end
   end
 
   describe '#snake_case' do