Merge pull request #7661 from Tietew/ast_regexp_multiline_fix

[Fix rubocop/rubocop-performance#95] Fix to return correct info from multi-line regexp

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Bug fixes
 
 * [#7639](https://github.com/rubocop-hq/rubocop/pull/7639): Fix logical operator edge case in `omit_parentheses` style of `Style/MethodCallWithArgsParentheses`. ([@gsamokovarov][])
+* [#7661](https://github.com/rubocop-hq/rubocop/pull/7661): Fix to return correct info from multi-line regexp. ([@Tietew][])
 
 ### Changes
 
@@ -4332,3 +4333,4 @@
 [@pirj]: https://github.com/pirj
 [@pawptart]: https://github.com/pawptart
 [@gfyoung]: https://github.com/gfyoung
+[@Tietew]: https://github.com/Tietew

lib/rubocop/ast/node/regexp_node.rb

@@ -21,14 +21,12 @@ def to_regexp
 
       # @return [RuboCop::AST::Node] a regopt node
       def regopt
-        first, second = *self
-        first.regopt_type? ? first : second
+        children.last
       end
 
       # @return [String] a string of regexp content
       def content
-        str = children.first
-        str.str_content || ''
+        children.select(&:str_type?).map(&:str_content).join
       end
     end
   end

spec/rubocop/ast/regexp_node_spec.rb

@@ -23,6 +23,12 @@
       it { expect(regexp_node.to_regexp).to eq(eval(source)) }
     end
 
+    context 'with a multi-line regexp without option' do
+      let(:source) { "/\n.+\n/" }
+
+      it { expect(regexp_node.to_regexp).to eq(eval(source)) }
+    end
+
     context 'with an empty regexp with option' do
       let(:source) { '//ix' }
 
@@ -34,6 +40,12 @@
 
       it { expect(regexp_node.to_regexp).to eq(eval(source)) }
     end
+
+    context 'with a multi-line regexp with option' do
+      let(:source) { "/\n.+\n/ix" }
+
+      it { expect(regexp_node.to_regexp).to eq(eval(source)) }
+    end
     # rubocop:enable Security/Eval
   end
 
@@ -54,6 +66,13 @@
       it { expect(regopt.children.empty?).to be(true) }
     end
 
+    context 'with a multi-line regexp without option' do
+      let(:source) { "/\n.+\n/" }
+
+      it { expect(regopt.regopt_type?).to be(true) }
+      it { expect(regopt.children.empty?).to be(true) }
+    end
+
     context 'with an empty regexp with option' do
       let(:source) { '//ix' }
 
@@ -67,6 +86,13 @@
       it { expect(regopt.regopt_type?).to be(true) }
       it { expect(regopt.children).to eq(%i[i m x]) }
     end
+
+    context 'with a multi-line regexp with option' do
+      let(:source) { "/\n.+\n/imx" }
+
+      it { expect(regopt.regopt_type?).to be(true) }
+      it { expect(regopt.children).to eq(%i[i m x]) }
+    end
   end
 
   describe '#content' do
@@ -84,6 +110,12 @@
       it { expect(content).to eq('.+') }
     end
 
+    context 'with a multi-line regexp without option' do
+      let(:source) { "/\n.+\n/" }
+
+      it { expect(content).to eq("\n.+\n") }
+    end
+
     context 'with an empty regexp with option' do
       let(:source) { '//ix' }
 
@@ -95,5 +127,11 @@
 
       it { expect(content).to eq('.+') }
     end
+
+    context 'with a multi-line regexp with option' do
+      let(:source) { "/\n.+\n/imx" }
+
+      it { expect(content).to eq("\n.+\n") }
+    end
   end
 end