Mark autocorrection for Lint/EmptyConditionalBody as unsafe.

rubocop · Aug 4, 2022 · b976534 · b976534
1 parent 0658f99
commit b976534
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog/fix_mark_autocorrection_for.md b/changelog/fix_mark_autocorrection_for.md
@@ -0,0 +1 @@
+* [#10867](https://github.com/rubocop/rubocop/pull/10867): Mark autocorrection for `Lint/EmptyConditionalBody` as unsafe. ([@dvandersluis][])
diff --git a/config/default.yml b/config/default.yml
@@ -1753,9 +1753,10 @@ Lint/EmptyClass:
 Lint/EmptyConditionalBody:
   Description: 'Checks for the presence of `if`, `elsif` and `unless` branches without a body.'
   Enabled: true
+  SafeAutoCorrect: false
   AllowComments: true
   VersionAdded: '0.89'
-  VersionChanged: '1.33'
+  VersionChanged: '<<next>>'
 
 Lint/EmptyEnsure:
   Description: 'Checks for empty ensure block.'

diff --git a/lib/rubocop/cop/lint/empty_conditional_body.rb b/lib/rubocop/cop/lint/empty_conditional_body.rb
@@ -7,6 +7,11 @@ module Lint
       #
       # NOTE: empty `else` branches are handled by `Style/EmptyElse`.
       #
+      # @safety
+      #   Autocorrection for this cop is not safe. The conditions for empty branches that
+      #   the autocorrection removes may have side effects, or the logic in subsequent
+      #   branches may change due to the removal of a previous condition.
+      #
       # @example
       #   # bad
       #   if condition