Merge pull request #10590 from nobuyo/fix-autocorrect-for-style-raise…

…-args-with-compact-style

[Fix #10589] Fix autocorrect for `Style/RaiseArgs` with `EnforcedStyle: compact`

changelog/fix_autocorrect_for_styleraiseargs.md

@@ -0,0 +1 @@
+* [#10589](https://github.com/rubocop/rubocop/issues/10589): Fix autocorrect for `Style/RaiseArgs` with `EnforcedStyle: compact` and exception object is assigned to a local variable. ([@nobuyo][])

lib/rubocop/cop/style/raise_args.rb

@@ -80,7 +80,7 @@ def correction_exploded_to_compact(node)
           return node.source if message_nodes.size > 1
 
           argument = message_nodes.first.source
-          exception_class = exception_node.const_name || exception_node.receiver.source
+          exception_class = exception_node.receiver&.source || exception_node.source
 
           if node.parent && requires_parens?(node.parent)
             "#{node.method_name}(#{exception_class}.new(#{argument}))"

spec/rubocop/cop/style/raise_args_spec.rb

@@ -17,6 +17,19 @@
       end
     end
 
+    context 'with a raise with 2 args and exception object is assigned to a local variable' do
+      it 'reports an offense' do
+        expect_offense(<<~RUBY)
+          raise error_class, msg
+          ^^^^^^^^^^^^^^^^^^^^^^ Provide an exception object as an argument to `raise`.
+        RUBY
+
+        expect_correction(<<~RUBY)
+          raise error_class.new(msg)
+        RUBY
+      end
+    end
+
     context 'with a raise with exception instantiation and message arguments' do
       it 'reports an offense' do
         expect_offense(<<~RUBY)
@@ -317,6 +330,10 @@ def do_something
       expect_no_offenses('raise RuntimeError, msg')
     end
 
+    it 'accepts a raise when exception object is assigned to a local variable' do
+      expect_no_offenses('raise error_class, msg')
+    end
+
     it 'accepts a raise with msg argument' do
       expect_no_offenses('raise msg')
     end