Merge pull request #6802 from pocke/fix-SymbolArray-auto-correct-with…

…-string-interpolation

Fix auto-correction for Style/SymbolArray with array contains interpolation

CHANGELOG.md

@@ -7,6 +7,7 @@
 * [#6699](https://github.com/rubocop-hq/rubocop/issues/6699): Fix infinite loop for `Layout/IndentationWidth` and `Layout/IndentationConsistency` when bad modifier indentation before good method definition. ([@koic][])
 * [#6777](https://github.com/rubocop-hq/rubocop/issues/6777): Fix a false positive for `Style/TrivialAccessors` when using trivial reader/writer methods at the top level. ([@koic][])
 * [#6799](https://github.com/rubocop-hq/rubocop/pull/6799): Fix errors for `Style/ConditionalAssignment`, `Style/IdenticalConditionalBranches`, `Lint/ElseLayout`, and `Layout/IndentationWidth` with empty braces. ([@pocke][])
+* [#6802](https://github.com/rubocop-hq/rubocop/pull/6802): Fix auto-correction for `Style/SymbolArray` with array contains interpolation when `EnforcedStyle` is `brackets`. ([@pocke][])
 
 ### Changes
 

lib/rubocop/cop/style/symbol_array.rb

@@ -70,7 +70,15 @@ def symbols_contain_spaces?(node)
         end
 
         def correct_bracketed(node)
-          syms = node.children.map { |c| to_symbol_literal(c.value.to_s) }
+          syms = node.children.map do |c|
+            if c.dsym_type?
+              string_literal = to_string_literal(c.source)
+
+              ':' + trim_string_interporation_escape_character(string_literal)
+            else
+              to_symbol_literal(c.value.to_s)
+            end
+          end
 
           lambda do |corrector|
             corrector.replace(node.source_range, "[#{syms.join(', ')}]")

lib/rubocop/cop/style/word_array.rb

@@ -96,10 +96,6 @@ def correct_bracketed(node)
             corrector.replace(node.source_range, "[#{words.join(', ')}]")
           end
         end
-
-        def trim_string_interporation_escape_character(str)
-          str.gsub(/\\\#{(.*?)\}/) { "\#{#{Regexp.last_match(1)}}" }
-        end
       end
     end
   end

lib/rubocop/cop/util.rb

@@ -85,6 +85,10 @@ def to_string_literal(string)
         end
       end
 
+      def trim_string_interporation_escape_character(str)
+        str.gsub(/\\\#{(.*?)\}/) { "\#{#{Regexp.last_match(1)}}" }
+      end
+
       def interpret_string_escapes(string)
         StringInterpreter.interpret(string)
       end

spec/rubocop/cop/style/symbol_array_spec.rb

@@ -149,7 +149,7 @@
     end
   end
 
-  context 'when EnforcedStyle is array' do
+  context 'when EnforcedStyle is brackets' do
     let(:cop_config) { { 'EnforcedStyle' => 'brackets', 'MinSize' => 0 } }
 
     it 'does not register an offense for arrays of symbols' do
@@ -167,6 +167,11 @@
       new_source = autocorrect_source('%i(one @two $three four-five)')
       expect(new_source).to eq("[:one, :@two, :$three, :'four-five']")
     end
+
+    it 'autocorrects an array has interpolations' do
+      new_source = autocorrect_source('%I(#{foo} #{foo}bar foo#{bar} foo)')
+      expect(new_source).to eq('[:"#{foo}", :"#{foo}bar", :"foo#{bar}", :foo]')
+    end
   end
 
   context 'with non-default MinSize' do