[Fix #9350] Wrap in parens before replacing unless with if and !

rubocop · Jan 9, 2021 · ad71469 · ad71469
1 parent d197cc4
commit ad71469
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog/fix_wrap_in_parens_before_replacing_unless.md b/changelog/fix_wrap_in_parens_before_replacing_unless.md
@@ -0,0 +1 @@
+* [#9350](https://github.com/rubocop-hq/rubocop/pull/9350): Wrap in parens before replacing `unless` with `if` and `!`. ([@magneland][])
diff --git a/lib/rubocop/cop/style/sole_nested_conditional.rb b/lib/rubocop/cop/style/sole_nested_conditional.rb
@@ -63,13 +63,13 @@ def offending_branch?(branch)
         end
 
         def autocorrect(corrector, node, if_branch)
+          corrector.wrap(node.condition, '(', ')') if node.condition.or_type?
+
           if node.unless?
             corrector.replace(node.loc.keyword, 'if')
             corrector.insert_before(node.condition, '!')
           end
 
-          corrector.wrap(node.condition, '(', ')') if node.condition.or_type?
-
           and_operator = if_branch.unless? ? ' && !' : ' && '
           if if_branch.modifier_form?
             correct_for_guard_condition_style(corrector, node, if_branch, and_operator)