Merge pull request #16 from jonas054/bugfix2

The first argument to Cop#add_offence shall be "severity".
rubocop · Jan 16, 2013 · aab4f65 · aab4f65
2 parents cb21e14 + 276bcac
commit aab4f65
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/lib/rubocop/cop/cop.rb b/lib/rubocop/cop/cop.rb
@@ -56,9 +56,9 @@ def has_report?
         !@offences.empty?
       end
 
-      def add_offence(file, line_number, message)
+      def add_offence(severity, line_number, message)
         if self.class.enabled != false
-          @offences << Offence.new(file, line_number, message)
+          @offences << Offence.new(severity, line_number, message)
         end
       end
 

diff --git a/spec/rubocop/cops/align_parameters_spec.rb b/spec/rubocop/cops/align_parameters_spec.rb
@@ -60,14 +60,14 @@ module Cop
 
       it 'can handle a correctly aligned string literal as first argument' do
         inspect_source(align, '',
-                       ['add_offence("", x,',
+                       ['add_offence(:convention, x,',
                         '            a)'])
         align.offences.map(&:message).should == []
       end
 
       it 'can handle a string literal as other argument' do
         inspect_source(align, '',
-                       ['add_offence(x,',
+                       ['add_offence(:convention,',
                         '            "", a)'])
         align.offences.map(&:message).should == []
       end

diff --git a/spec/rubocop/cops/cop_spec.rb b/spec/rubocop/cops/cop_spec.rb
@@ -16,13 +16,13 @@ module Cop
       end
 
       it 'keeps track of offences' do
-        cop.add_offence('file', 1, 'message')
+        cop.add_offence(:convention, 1, 'message')
 
         cop.offences.size.should == 1
       end
 
       it 'will report registered offences' do
-        cop.add_offence('file', 1, 'message')
+        cop.add_offence(:convention, 1, 'message')
 
         cop.has_report?.should be_true
       end