Merge pull request #11484 from fatkodima/fix-closing_parenthesis_inde…

…ntation Fix `Layout/ClosingParenthesisIndentation` for keyword splat arguments
rubocop · Jan 23, 2023 · 99c8b17 · 99c8b17
2 parents 51ded37 + 809ca3a
commit 99c8b17
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/changelog/fix_closing_parenthesis_indentation_for_keyword_splat.md b/changelog/fix_closing_parenthesis_indentation_for_keyword_splat.md
@@ -0,0 +1 @@
+* [#11483](https://github.com/rubocop/rubocop/issues/11483): Fix `Layout/ClosingParenthesisIndentation` for keyword splat arguments. ([@fatkodima][])
diff --git a/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb b/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb
@@ -157,7 +157,7 @@ def expected_column(left_paren, elements)
         def all_elements_aligned?(elements)
           elements.flat_map do |e|
             if e.hash_type?
-              e.each_pair.map { |pair| pair.loc.column }
+              e.each_child_node.map { |child| child.loc.column }
             else
               e.loc.column
             end

diff --git a/spec/rubocop/cop/layout/closing_parenthesis_indentation_spec.rb b/spec/rubocop/cop/layout/closing_parenthesis_indentation_spec.rb
@@ -57,6 +57,14 @@
         RUBY
       end
 
+      it 'does not register an offense when using keyword splat arguments' do
+        expect_no_offenses(<<~RUBY)
+          some_method(x,
+            **options
+          )
+        RUBY
+      end
+
       it 'accepts a correctly indented )' do
         expect_no_offenses(<<~RUBY)
           some_method(a,