Merge pull request #8851 from dvandersluis/issue/8848

[Fix #8848] Fix a false positive for `Style/CombinableLoops` when using the same method with different arguments

CHANGELOG.md

@@ -17,6 +17,7 @@
 * [#8354](https://github.com/rubocop-hq/rubocop/issues/8354): Detect regexp named captures in `Style/CaseLikeIf` cop. ([@dsavochkin][])
 * [#8830](https://github.com/rubocop-hq/rubocop/issues/8830): Fix bad autocorrect of `Style/StringConcatenation` when string includes double quotes. ([@tleish][])
 * [#8807](https://github.com/rubocop-hq/rubocop/pull/8807): Fix a false positive for `Style/RedundantCondition` when using assignment by hash key access. ([@koic][])
+* [#8848](https://github.com/rubocop-hq/rubocop/issues/8848): Fix a false positive for `Style/CombinableLoops` when using the same method with different arguments. ([@dvandersluis][])
 
 ### Changes
 

docs/modules/ROOT/pages/cops_style.adoc

@@ -1437,6 +1437,12 @@ def method
     do_something_else(item)
   end
 end
+
+# good
+def method
+  each_slice(2) { |slice| do_something(slice) }
+  each_slice(3) { |slice| do_something(slice) }
+end
 ----
 
 == Style/CommandLiteral

lib/rubocop/cop/style/combinable_loops.rb

@@ -49,6 +49,12 @@ module Style
       #     end
       #   end
       #
+      #   # good
+      #   def method
+      #     each_slice(2) { |slice| do_something(slice) }
+      #     each_slice(3) { |slice| do_something(slice) }
+      #   end
+      #
       class CombinableLoops < Base
         MSG = 'Combine this loop with the previous loop.'
 
@@ -76,7 +82,8 @@ def collection_looping_method?(node)
         def same_collection_looping?(node, sibling)
           sibling&.block_type? &&
             sibling.send_node.method?(node.method_name) &&
-            sibling.send_node.receiver == node.send_node.receiver
+            sibling.send_node.receiver == node.send_node.receiver &&
+            sibling.send_node.arguments == node.send_node.arguments
         end
       end
     end

spec/rubocop/cop/style/combinable_loops_spec.rb

@@ -53,6 +53,13 @@
         end
       RUBY
     end
+
+    it 'does not register an offense for when the same method with different arguments' do
+      expect_no_offenses(<<~RUBY)
+        each_slice(2) { |slice| do_something(slice) }
+        each_slice(3) { |slice| do_something(slice) }
+      RUBY
+    end
   end
 
   context 'when for loop' do