Update terminology in rails/validation.rb

rubocop · Nov 12, 2018 · 9968b0f · 9968b0f
1 parent 4910866
commit 9968b0f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/rubocop/cop/rails/validation.rb b/lib/rubocop/cop/rails/validation.rb
@@ -47,11 +47,11 @@ class Validation < Cop
           uniqueness
         ].freeze
 
-        BLACKLIST = TYPES.map { |p| "validates_#{p}_of".to_sym }.freeze
-        WHITELIST = TYPES.map { |p| "validates :column, #{p}: value" }.freeze
+        DENYLIST = TYPES.map { |p| "validates_#{p}_of".to_sym }.freeze
+        ALLOWLIST = TYPES.map { |p| "validates :column, #{p}: value" }.freeze
 
         def on_send(node)
-          return unless !node.receiver && BLACKLIST.include?(node.method_name)
+          return unless !node.receiver && DENYLIST.include?(node.method_name)
 
           add_offense(node, location: :selector)
         end
@@ -71,7 +71,7 @@ def message(node)
         end
 
         def preferred_method(method)
-          WHITELIST[BLACKLIST.index(method.to_sym)]
+          ALLOWLIST[DENYLIST.index(method.to_sym)]
         end
 
         def correct_validate_type(corrector, node)

diff --git a/spec/rubocop/cop/rails/validation_spec.rb b/spec/rubocop/cop/rails/validation_spec.rb
@@ -3,7 +3,7 @@
 RSpec.describe RuboCop::Cop::Rails::Validation do
   subject(:cop) { described_class.new }
 
-  described_class::BLACKLIST.each_with_index do |validation, number|
+  described_class::DENYLIST.each_with_index do |validation, number|
     it "registers an offense for #{validation}" do
       inspect_source("#{validation} :name")
       expect(cop.offenses.size).to eq(1)
@@ -12,7 +12,7 @@
     it "outputs the correct message for #{validation}" do
       inspect_source("#{validation} :name")
       expect(cop.offenses.first.message)
-        .to include(described_class::WHITELIST[number])
+        .to include(described_class::ALLOWLIST[number])
     end
   end