Merge pull request #9645 from koic/fix_incorrect_autocorrect_for_styl…

…e_single_line_methods Fix an incorrect auto-correct for `Style/SingleLineMethods`
rubocop · Mar 29, 2021 · 9758a56 · 9758a56
2 parents 8110f8f + cf166e2
commit 9758a56
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/changelog/fix_incorrect_autocorrect_for_style_single_line_methods.md b/changelog/fix_incorrect_autocorrect_for_style_single_line_methods.md
@@ -0,0 +1 @@
+* [#9645](https://github.com/rubocop/rubocop/pull/9645): Fix an incorrect auto-correct for `Style/SingleLineMethods` when using single line class method definition. ([@koic][])
diff --git a/lib/rubocop/cop/style/single_line_methods.rb b/lib/rubocop/cop/style/single_line_methods.rb
@@ -91,8 +91,9 @@ def correct_to_multiline(corrector, node)
         end
 
         def correct_to_endless(corrector, node)
+          self_receiver = node.self_receiver? ? 'self.' : ''
           arguments = node.arguments.any? ? node.arguments.source : '()'
-          replacement = "def #{node.method_name}#{arguments} = #{node.body.source}"
+          replacement = "def #{self_receiver}#{node.method_name}#{arguments} = #{node.body.source}"
           corrector.replace(node, replacement)
         end
 

diff --git a/spec/rubocop/cop/style/single_line_methods_spec.rb b/spec/rubocop/cop/style/single_line_methods_spec.rb
@@ -168,6 +168,12 @@ def some_method() = body
         RUBY
       end
 
+      it 'corrects to an endless class method definition' do
+        expect_correction(<<~RUBY.strip, source: 'def self.some_method; body end')
+          def self.some_method() = body
+        RUBY
+      end
+
       it 'retains comments' do
         source = 'def some_method; body end # comment'
         expect_correction(<<~RUBY.strip, source: source)