[Fix #10394] Fix an error for Style/SwapValues

Fixes #10394. This PR fixes an error for `Style/SwapValues` when assigning receiver object at `def`.
rubocop · Feb 3, 2022 · 7e09781 · 7e09781
1 parent 0bbc02e
commit 7e09781
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/changelog/fix_an_error_for_style_swap_values.md b/changelog/fix_an_error_for_style_swap_values.md
@@ -0,0 +1 @@
+* [#10394](https://github.com/rubocop/rubocop/issues/10394): Fix an error for `Style/SwapValues` when assigning receiver object at `def`. ([@koic][])
diff --git a/lib/rubocop/cop/style/swap_values.rb b/lib/rubocop/cop/style/swap_values.rb
@@ -58,6 +58,8 @@ def swapping_values?(tmp_assign, x_assign, y_assign)
         end
 
         def simple_assignment?(node)
+          return false unless node.respond_to?(:type)
+
           SIMPLE_ASSIGNMENT_TYPES.include?(node.type)
         end
 

diff --git a/spec/rubocop/cop/style/swap_values_spec.rb b/spec/rubocop/cop/style/swap_values_spec.rb
@@ -52,4 +52,11 @@
       y = not_a_tmp
     RUBY
   end
+
+  it 'does not register an offense when assigning receiver object at `def`' do
+    expect_no_offenses(<<~RUBY)
+      def (foo = Object.new).do_something
+      end
+    RUBY
+  end
 end