[Fix #11173] Fix an incorrect autocorrect for Style/CollectionCompact

Fixes #11173. This PR fixes an incorrect autocorrect for `Style/CollectionCompact` when using `reject` with block pass arg and no parentheses.
rubocop · Nov 12, 2022 · 7b265aa · 7b265aa
1 parent dfb1ca5
commit 7b265aa
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/changelog/fix_incorrect_autocorrect_for_style_collection_compact.md b/changelog/fix_incorrect_autocorrect_for_style_collection_compact.md
@@ -0,0 +1 @@
+* [#11173](https://github.com/rubocop/rubocop/issues/11173): Fix an incorrect autocorrect for `Style/CollectionCompact` when using `reject` with block pass arg and no parentheses. ([@koic][])
diff --git a/lib/rubocop/cop/style/collection_compact.rb b/lib/rubocop/cop/style/collection_compact.rb
@@ -112,7 +112,7 @@ def good_method_name(node)
         end
 
         def range(begin_pos_node, end_pos_node)
-          range_between(begin_pos_node.loc.selector.begin_pos, end_pos_node.loc.end.end_pos)
+          range_between(begin_pos_node.loc.selector.begin_pos, end_pos_node.loc.expression.end_pos)
         end
       end
     end

diff --git a/spec/rubocop/cop/style/collection_compact_spec.rb b/spec/rubocop/cop/style/collection_compact_spec.rb
@@ -29,6 +29,17 @@
     RUBY
   end
 
+  it 'registers an offense and corrects when using `reject` with block pass arg and no parentheses' do
+    expect_offense(<<~RUBY)
+      array.reject &:nil?
+            ^^^^^^^^^^^^^ Use `compact` instead of `reject &:nil?`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      array.compact
+    RUBY
+  end
+
   it 'registers an offense and corrects when using `reject` on hash to reject nils' do
     expect_offense(<<~RUBY)
       hash.reject { |k, v| v.nil? }